pinctrl: imx: fix memory leak

Each time set_state is called, a new piece memory will
be allocated for pin_data, but not freed, this will
incur memory leak.

When error, the devm API could not free memory automatically.
So need call devm_kfree when error.

Issue reported by Coverity

Signed-off-by: Peng Fan <[email protected]>
Cc: Simon Glass <[email protected]>
Cc: Stefan Agner <[email protected]>
Cc: Stefano Babic <[email protected]>

diff --git a/drivers/pinctrl/nxp/pinctrl-imx.c b/drivers/pinctrl/nxp/pinctrl-imx.c
index f0321c4057651cf3d2a89f5d3f80f5f2a5687ba1..ebc14a31f1ec103f8954789004de1469ae8792b4 100644 (file)
--- a/drivers/pinctrl/nxp/pinctrl-imx.c
+++ b/drivers/pinctrl/nxp/pinctrl-imx.c
@@ -53,6 +53,7 @@ static int imx_pinctrl_set_state(struct udevice *dev, struct udevice *config)
        if (fdtdec_get_int_array(gd->fdt_blob, node, "fsl,pins",
                                 pin_data, size >> 2)) {
                dev_err(dev, "Error reading pin data.\n");
+               devm_kfree(dev, pin_data);
                return -EINVAL;
        }
 
@@ -78,6 +79,7 @@ static int imx_pinctrl_set_state(struct udevice *dev, struct udevice *config)
 
                if ((mux_reg == -1) || (conf_reg == -1)) {
                        dev_err(dev, "Error mux_reg or conf_reg\n");
+                       devm_kfree(dev, pin_data);
                        return -EINVAL;
                }
 
@@ -166,6 +168,8 @@ static int imx_pinctrl_set_state(struct udevice *dev, struct udevice *config)
                }
        }
 
+       devm_kfree(dev, pin_data);
+
        return 0;
 }